Share the selection between Tilesets view and Tileset Editor#3768
Open
bjorn wants to merge 1 commit intomapeditor:masterfrom
Open
Share the selection between Tilesets view and Tileset Editor#3768bjorn wants to merge 1 commit intomapeditor:masterfrom
bjorn wants to merge 1 commit intomapeditor:masterfrom
Conversation
Member
Author
bjorn
force-pushed
the
shared-tileset-selection
branch
from
9fd7669 to
4c2ab41
Compare
bjorn
force-pushed
the
shared-tileset-selection
branch
from
4c2ab41 to
ec6b9e2
Compare
bjorn
force-pushed
the
shared-tileset-selection
branch
2 times, most recently
from
9297068 to
0c4d7fe
Compare
Member
Author
|
Patch was broken during one of the rebases. A helpful message was printed to the console when opening a tileset in the Tileset Editor: Of course we needed to use the model from the |
Now TilesetDocument owns a single TilesetModel and associated QItemSelectionModel, which are used by the TilesetView instances in the TilesetDock as well as in the TilesetEditor.
bjorn
force-pushed
the
shared-tileset-selection
branch
from
0c4d7fe to
7a2c8ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
TilesetDocumentowns a singleTilesetModeland associatedQItemSelectionModel, which are used by theTilesetViewinstances in theTilesetDockas well as in theTilesetEditor.